Skip to content

fix(tests): keep sweep import probe portable on Python 3.10 - #550

Merged
solomonneas merged 1 commit into
mainfrom
fix/545-python310-regression
Jul 26, 2026
Merged

fix(tests): keep sweep import probe portable on Python 3.10#550
solomonneas merged 1 commit into
mainfrom
fix/545-python310-regression

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

Root cause

PR #545’s regression test disabled site-packages and then started the full Brigade CLI. Python 3.10 has no standard-library tomllib, while python -S also hides the installed tomli fallback. The test therefore failed during CLI startup instead of checking the sweep subprocess import root.

Verification

  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
  • Receipt: 20260726-194952-work-verify-60c994
  • Exit code: 0
  • Result: 4297 passed, 3 skipped with 82.80% coverage

Follow-up to #545.

Co-authored-by: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d27f140-6857-47a4-ae9f-2fb38243b439

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/545-python310-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 26, 2026
@solomonneas
solomonneas merged commit f11725b into main Jul 26, 2026
28 checks passed
@solomonneas
solomonneas deleted the fix/545-python310-regression branch July 26, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant