feat(runs): add lifecycle journal kernel - #607
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Codex <codex@openai.com>
solomonneas
marked this pull request as ready for review
July 28, 2026 20:00
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the journal kernel for #568 without wiring it into active run transitions yet.
brigade.run_event.v1envelope, event registry, payload allowlists, and deterministic digests.fsync.O_NOFOLLOW,O_DIRECTORY, orfchmod.Design notes
event_idcontains the first 12 characters ofevent_digest. The digest input therefore excludes bothevent_digestandevent_id. Includingevent_idwould require a SHA-256 fixed point.This PR stops at the typed storage kernel. It does not change
aboyeur.py, write lifecycle events from live runs, or project them intorun.json. Those changes belong to the next #568 slice.Verification
python -m pytest tests/test_run_events.py tests/test_run_journal.py -q: 86 passed../scripts/verify: 4,816 passed, 3 skipped, 82.91% coverage. Ruff lint, Ruff format, mypy, version sync, and managed snapshot checks passed.Part of #568.