picolibc: add check for --cfg espidf_picolibc#414
Open
drinkcat wants to merge 2 commits into
Open
Conversation
drinkcat
force-pushed
the
idf-6.0-picolibc
branch
from
36a4677 to
543d372
Compare
Contributor
Author
|
Removed the hack. libc 0.2.185 has been released so this should be good to go. |
drinkcat
changed the title
--cfg espidf_picolibc--cfg espidf_picolibc
…port ESP-IDF v6.0 switched from newlib to picolibc as default C library. Add compile-time checks that enforce the espidf_picolibc rustc cfg flag is set (or unset) consistently with the ESP-IDF sdkconfig, and that libc::O_APPEND matches the expected value. Update CI to pass --cfg espidf_picolibc for v6 builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
drinkcat
force-pushed
the
idf-6.0-picolibc
branch
from
543d372 to
9d712ef
Compare
Collaborator
I'm not 100% sure. :-( The thing is, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
Makes sure that
--cfg espidf_picolibcis set if picolibc is selected, and update CI.Question: Do we want to test newlib config on esp-idf 6.0+? We could add to the CI matrix if we wanted to.
Not quite merge-able as-is, the third HACK commit will need to be removed when the nextlibc0.2 is released (looks reasonably frequent so we could just wait I guess).Testing
Local, then CI.