You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Callback change in a command can be useful in some scenarios where other functionality different from the original is required. Just like the possibility that already exist to override the callback for an attribute.
Out of curiosity, can you give an example where this is helpful?
From my understanding (by looking at the IMClusterCommandHandler.cpp file), for the standard commands, the API which needs to be eventually called was very specific (example emberAfOnOffClusterOnCallback) and this API was implemented in Matter's cluster code.
I am also wondering if a COMMAND_FLAG_OVERRIDE needs to be added, similar to the ATTRIBUTE_FLAG_OVERRIDE, and if that will be useful when calling this callback.
Currently, in esp-matter, for commands with COMMAND_FLAG_CUSTOM, the default response is sent internally based on the return value from the callback.
Out of curiosity, can you give an example where this is helpful?
From my understanding (by looking at the IMClusterCommandHandler.cpp file), for the standard commands, the API which needs to be eventually called was very specific (example emberAfOnOffClusterOnCallback) and this API was implemented in Matter's cluster code.
Sure, it might be helpful when the Matter's cluster code doesn't satisfy the needs or isn't very flexible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback change in a command can be useful in some scenarios where other functionality different from the original is required. Just like the possibility that already exist to override the callback for an attribute.