source-*: check rows.Err() after all rows.Next() loops#4233
Merged
Conversation
Per Go's database/sql docs, `rows.Next()` returns false both when the result set is exhausted and when an error is encountered. `rows.Err()` must be checked afterward to distinguish the two cases. Without this check, a mid-iteration error causes the function to return success with a partial result set.
willdonnelly
approved these changes
Apr 13, 2026
Member
willdonnelly
left a comment
willdonnelly
left a comment
There was a problem hiding this comment.
LGTM
If I'm reading this correctly it looks like there's one significant data-correctness issue fixed here (in the source-oracle backfill code) and the rest is all discovery/prerequisites/diagnostics (which are still good to detect errors on, but significantly less likely to cause real user harm). That's better than I expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Per Go's database/sql docs,
rows.Next()returnsfalseboth when the result set is exhausted and when an error is encountered.rows.Err()must be checked afterward to distinguish the two cases. Without this check, a mid-iteration error causes the function to return success with a partial result set.Notes for reviewers:
There are also materializations that aren't checking
rows.Err()after iterating throughrows.Next(), but I'm going to split those off into a different PR for the materialization team to review.