Conversation
Per Go's database/sql docs, `rows.Next()` returns false both when the result set is exhausted and when an error is encountered. `rows.Err()` must be checked afterward to distinguish the two cases. Without this check, a mid-iteration error causes the function to return success with a partial result set.
mdibaiee
approved these changes
Apr 13, 2026
Alex-Bair
deleted the
bair/materialize-{various}-check-rows-err-after-iteration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is the materialization counterpart of #4233.
Per Go's database/sql docs,
rows.Next()returnsfalseboth when the result set is exhausted and when an error is encountered.rows.Err()must be checked afterward to distinguish the two cases. Without this check, a mid-iteration error causes the function to return success with a partial result set.I also added a
defer rows.Close()in a spot inmaterailize-sqlserverthat was missing it.Notes for reviewers:
When investigating an escalation for
source-sqlserver, we found that it wasn't checkingrows.Err()after iterating throughrows.Next()and could have missed changes as a result of that bug. I'm going through and updating all connectors to make sure they checkrows.Err()so we don't encounter the same bug elsewhere, and this PR is a part of that effort. I'm not as familiar with materializations, so feel free to tell me to do things differently if these changes aren't applicable for whatever reason. 😁