materialize-*: check rows.Err() after all rows.Next() loops

materialize-azure-fabric-warehouse/client.go

@@ -266,6 +266,9 @@ func (c *client) ListSchemas(ctx context.Context) ([]string, error) {
 		}
 		out = append(out, schema)
 	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterating rows: %w", err)
+	}
 
 	return out, nil
 }

materialize-motherduck/client.go

@@ -122,6 +122,9 @@ func (c *client) ListSchemas(ctx context.Context) ([]string, error) {
 		}
 		out = append(out, schema)
 	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterating rows: %w", err)
+	}
 
 	return out, nil
 }

materialize-motherduck/config.go

@@ -325,6 +325,9 @@ func (c *config) db(ctx context.Context) (*stdsql.DB, error) {
 			log.WithField("name", name).Warn("unexpected secret selected")
 		}
 	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterating selected secrets: %w", err)
+	}
 
 	return db, err
 }

materialize-redshift/client.go

@@ -142,6 +142,9 @@ func (c *client) ListSchemas(ctx context.Context) ([]string, error) {
 		}
 		out = append(out, schema)
 	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterating rows: %w", err)
+	}
 
 	return out, nil
 }

materialize-sql/std_sql.go

@@ -223,6 +223,9 @@ func StdDumpTable(ctx context.Context, db *sql.DB, table Table) (string, error)
 			b.WriteString(val.String())
 		}
 	}
+	if err := rows.Err(); err != nil {
+		return "", err
+	}
 	return b.String(), nil
 }
 
@@ -439,6 +442,9 @@ func StdListSchemas(ctx context.Context, db *sql.DB) ([]string, error) {
 		}
 		out = append(out, schema)
 	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterating rows: %w", err)
+	}
 
 	return out, nil
 }

materialize-sql/test_support.go

@@ -429,5 +429,8 @@ func DumpTestTable(t *testing.T, db *stdsql.DB, qualifiedTableName string) (stri
 			b.WriteString(val.String())
 		}
 	}
+	if err := rows.Err(); err != nil {
+		return "", err
+	}
 	return b.String(), nil
 }

materialize-sqlserver/collation.go

@@ -35,6 +35,7 @@ func getCollation(ctx context.Context, db *stdsql.DB) (string, error) {
 	if err != nil {
 		return "", fmt.Errorf("querying available collations: %w", err)
 	}
+	defer rows.Close()
 
 	var collations []string
 	for rows.Next() {
@@ -45,6 +46,9 @@ func getCollation(ctx context.Context, db *stdsql.DB) (string, error) {
 
 		collations = append(collations, c)
 	}
+	if err := rows.Err(); err != nil {
+		return "", fmt.Errorf("iterating collations: %w", err)
+	}
 
 	sortCollations(collations)
 

materialize-starburst/starburst.go

@@ -329,6 +329,9 @@ func (t *transactor) Load(it *m.LoadIterator, loaded func(int, json.RawMessage)
 				return err
 			}
 		}
+		if err := rows.Err(); err != nil {
+			return fmt.Errorf("iterating Load documents: %w", err)
+		}
 
 		if err := rows.Close(); err != nil {
 			return fmt.Errorf("closing rows: %w", err)