Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golangci-lint v1.64.5 #216

Merged

Conversation

Elbehery
Copy link
Member

@Elbehery Elbehery mentioned this pull request Feb 21, 2025
@Elbehery
Copy link
Member Author

linter failure

 Error: cmd/extract.go:160:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
  		} else {
  			return printLeafItemValue(kv, outMediaType, out)
  		}
  
  Error: issues found

@Elbehery
Copy link
Member Author

/assign @ahrtr

Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery force-pushed the 20250221-bump-go-linter-1.64.5 branch from c4c95ac to 4961fc4 Compare February 25, 2025 09:07
@Elbehery
Copy link
Member Author

/assign @ivanvc

@Elbehery
Copy link
Member Author

/assign @siyuanfoundation

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery, ivanvc
Once this PR has been reviewed and has the lgtm label, please ask for approval from siyuanfoundation. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation siyuanfoundation merged commit 9bde47b into etcd-io:main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants