Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable testifylint #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mmorel-35
Copy link
Contributor

Description

Enables testifylint linter and uses testify instead of t.Fatal(f)

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 marked this pull request as ready for review March 7, 2025 19:25
@mmorel-35 mmorel-35 force-pushed the testifylint branch 2 times, most recently from 264aa5c to d0bb7f0 Compare March 8, 2025 07:46
@k8s-ci-robot
Copy link

@mmorel-35: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-test-2-cpu-arm64 d0bb7f0 link true /test pull-bbolt-test-2-cpu-arm64
pull-bbolt-test-1-cpu-arm64 d0bb7f0 link true /test pull-bbolt-test-1-cpu-arm64
pull-bbolt-test-4-cpu-arm64 d0bb7f0 link true /test pull-bbolt-test-4-cpu-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mmorel-35 mmorel-35 force-pushed the testifylint branch 6 times, most recently from b97ef3a to 65eeab2 Compare March 8, 2025 09:03
@mmorel-35 mmorel-35 marked this pull request as draft March 8, 2025 09:18
@mmorel-35 mmorel-35 marked this pull request as ready for review March 8, 2025 09:50
Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants