Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation and Improve Clarity in Smart Contracts #925

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Documentation and Improve Clarity in Smart Contracts #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b58c10
Update IERC6464.sol
maximevtush Feb 26, 2025
796ae44
Update ILockingContract.sol
maximevtush Feb 26, 2025
f3d372f
Update LibAccessLayers.sol
maximevtush Feb 26, 2025
9368862
Merge branch 'master' into master
maximevtush Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/erc-6464/contracts/IERC6464.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ interface IERC6464 is ERC721 {
function revokeAllExplicitApprovals() external;

/**
* @notice Revokes all excplicit approvals granted for the specified token.
* @notice Revokes all explicit approvals granted for the specified token.
* @dev Throws if `msg.sender` is not the current NFT owner, or an authorised operator of the current owner.
* @dev MUST emit `AllExplicitApprovalsRevoked(msg.sender, tokenId)`.
*/
Expand Down
2 changes: 1 addition & 1 deletion assets/erc-7573/contracts/ILockingContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pragma solidity >=0.7.0;
* This is the locking contracts interface.
*
* The rationale is that the token is locked with two encrypted keys
* or hashes of keys associated with two different adresses (buyer/seller).
* or hashes of keys associated with two different addresses (buyer/seller).
*
* The asset is transferred to the address of the buyer, if the buyer's key is presented.
*
Expand Down
10 changes: 5 additions & 5 deletions assets/erc-7746/test/LibAccessLayers.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ library LibAccessLayers {
bytes32 constant ACCESS_LAYERS_STORAGE_POSITION = keccak256("lib.access.layer.storage");

struct LayerStruct {
address layerAddess;
address layerAddress;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peersky I assume you're okay with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for fixing!

bytes4 beforeSig;
bytes4 afterSig;
bytes layerConfigData;
Expand All @@ -27,7 +27,7 @@ library LibAccessLayers {
bytes4 afterCallMethodSignature
) internal {
LayerStruct[] storage ls = accessLayersStorage();
ls[layerIndex].layerAddess = layerAddress;
ls[layerIndex].layerAddress = layerAddress;
ls[layerIndex].layerConfigData = layerConfigData;
ls[layerIndex].beforeSig = beforeCallMethodSignature;
ls[layerIndex].afterSig = afterCallMethodSignature;
Expand All @@ -52,7 +52,7 @@ library LibAccessLayers {
) internal {
LayerStruct[] storage ls = accessLayersStorage();
LayerStruct memory newLayer = LayerStruct({
layerAddess: layerAddress,
layerAddress: layerAddress,
layerConfigData: layerConfigData,
beforeSig: beforeCallMethodSignature,
afterSig: afterCallMethodSignature
Expand Down Expand Up @@ -91,7 +91,7 @@ library LibAccessLayers {
bytes memory data,
uint256 value
) internal returns (bytes memory) {
bytes memory retval = ILayer(layer.layerAddess).beforeCallValidation(
bytes memory retval = ILayer(layer.layerAddress).beforeCallValidation(
layer.layerConfigData,
_selector,
sender,
Expand Down Expand Up @@ -138,7 +138,7 @@ library LibAccessLayers {
uint256 value,
bytes memory beforeCallReturnValue
) internal {
ILayer(layer.layerAddess).afterCallValidation(
ILayer(layer.layerAddress).afterCallValidation(
layer.layerConfigData,
_selector,
sender,
Expand Down
Loading