-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests) EIP-2929: Gas cost increase tests #1305
base: main
Are you sure you want to change the base?
Conversation
pytest.param( | ||
{ | ||
"address": 0x08, | ||
"value": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so looks like the parametrization in all this tests really is
adress, value, output size.
it can be one test with that many parametrizations
for each addesss
for each value
for each output size
and so on. if the test body does not change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had issues with parametrizing with expected values that depend on specific inputs. Ended up changing these to parametrize the inputs and created separate tests for the permutations of the expected output.
I noticed the expected gas cost for many cases are different from the original tests. I'm looking at those closely to figure out the actual values to use, there may be additional changes to the contract based on certain scenarios. I'll check dr to figure out the differences there.
Does the current approach seem reasonable? If so, I plan to add the remaining test cases that use CALLCODE
, DELEGATECALL
, etc.
9335560
to
b760963
Compare
b760963
to
82800a0
Compare
61e278e
to
bb83ec9
Compare
ποΈ Description
Converted tests for gas cost increases from EIP-2929.
π Related Issues
#972 (stPreCompiledContracts / stPreCompiledContracts2)
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.