-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests) Additional precompile tests for blake2b, identity #1244
base: main
Are you sure you want to change the base?
Conversation
19ae03c
to
b10bd8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marioevz @winsvega I'm working on several more precompile tests and double checking that all cases are covered.
- Blake2b should be covered with these additions, but one case is causing timeouts (see separate comment below).
- This PR includes a couple Identity test cases. There are numerous others for CALL and CALLCODE that I will add here.
I want to clarify the other test cases since you mentioned skipping a few from the stPreCompiledContracts2 directory.
- Am I remembering that you said to ignore the ecrecover, ripemd and sha256 tests? I dont know if there might be others, but wanted to check back before I proceed further.
- I noticed a single test case in https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stPreCompiledContracts/sec80Filler.json that appears to be related to the ecrecover precompile (I found it runs
CALLCODE
to address 0x1). Should this one be ignored? The precompile EIP2929 tests should probably be converted. I wanted to check before implementing those, they appear to check gas consumption of certain opcodes. https://github.com/ethereum/tests/blob/develop/src/GeneralStateTestsFiller/stPreCompiledContracts/precompsEIP2929CancunFiller.yml- EIP-2929 test conversions are in feat(tests) EIP-2929: Gas cost increase testsΒ #1305
5c29b09
to
7882fc1
Compare
add tests to converted file to run check the coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add converted-tests .txt records to check run the coverage
60723e8
to
3be54a3
Compare
e2c0180
to
f13de88
Compare
8972e36
to
1c0bbc3
Compare
Add blake2 coverage for CALL, DELEGATECALL, CALLCODE tests Update blake2 REFERENCE_SPEC_VERSION to correct value
abd4708
to
30b1070
Compare
β¦ rounds Timeout fix for CALLCODE blake2 tests
d2e792f
to
630687f
Compare
Added a line to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, some comments that would make use of some pytest features to remove some code duplication. Thanks!
e975154
to
14d6f53
Compare
Test coverage is failing due to one case being skipped in |
ποΈ Description
Convert remaining Blake2 precompile test cases for CALL and DELEGATECALL
π Related Issues
#972 (stPreCompiledContracts / stPreCompiledContracts2)
ποΈ ethereum/tests removals:
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.