fix(tests): EOF - Change kind_data from 0x04 to 0xff

[pdobacz]

🗒️ Description

Align with eof-devnet-1 changes ipsilon/eof#173. Fills with evmone after a respective update, will be referenced soon 👇

🔗 Related Issues

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[marioevz]

Some minor suggestions, but overall looks good to me!

[marioevz]

What about doing something like VERSION_MAX_NON_DATA_SECTION_KIND?

[pdobacz]

I'm skeptical. It was used in only 3 spots in one test. Also, this abstraction might not hold in future designs, e.g. metadata section kind might end up being at 5 skipping 4, so a concept like max section kind is a bit misleading. It might not be a contiguous key list.

[winsvega]

@marioevz
this is what I mean. one byte change in the format and we have to correct all the tests.
in this case I think it is better we have a few unit tests for eof format builder.
and disable expected_bytecode validation in most of EOF tests. unless EOF want to stay super secure and maintain it.

[pdobacz]

I second this