feat(tests): Blake2 test spec refactor #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add files for spec and common variables and constants
reedsa
added
the
type:test
marioevz
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
Looks great!
Pushed two commits to improve readability of the changes between each test case:
- h, m, t0 and t1 now default to the most common used values to remove these lines, and makes it easier to visualize what the changes are between each case.
- Changed the IDs to match the test scenario rather than the ethereum/tests ID
Hashed the outputs between the changes I pushed and the previous commit in the PR and the outputs were identical.
Will merge in a bit!
8 tasks
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* Blake2 test spec refactor Add files for spec and common variables and constants * CHANGELOG.md * refactor(tests): EIP-152: Spec m, h, t0, t1 defaults * refactor(tests): EIP-152: test IDs --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Follow on to #1244 to add a spec file with common variables and constants.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.