feat(cli): resolve updated execution_spec exceptions#1784
Merged
spencer-tb merged 4 commits intoethereum:mainfrom Jul 29, 2025
Merged
feat(cli): resolve updated execution_spec exceptions#1784spencer-tb merged 4 commits intoethereum:mainfrom
spencer-tb merged 4 commits intoethereum:mainfrom
Conversation
spencer-tb
added
type:feat
spencer-tb
changed the title
4 tasks
souradeep-das
commented
Jul 17, 2025
souradeep-das
commented
Jul 28, 2025
Collaborator
|
Sorry! I completely missed this. Looking now :) |
Collaborator
|
Okay great! This already caught some issues. Would it be possible to rebase this PR onto main? It might be easier to drop the other commits, to start fresh and add a single commit with just the eels exception changes. Then force push etc. |
spencer-tb
reviewed
Jul 28, 2025
Collaborator
spencer-tb
left a comment
spencer-tb
left a comment
There was a problem hiding this comment.
Added a couple small comments!
Ohh and can we add this:
TransactionException.GAS_LIMIT_EXCEEDS_MAXIMUM: "TransactionGasLimitExceededError",
5 tasks
souradeep-das
force-pushed
the
souradeep/custom_exc
branch
from
5344bcd to
a14a713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Specific exceptions were added to execution_spec
InvalidTransactiontypes. This is a complementary update to accommodate for these specific exceptions.Exception types and details are outlined here:
🔗 Related Issues
ethereum/execution-specs#1021
✅ Checklist