chore(tests|forks): add max blobs per tx limit#1884
Merged
spencer-tb merged 1 commit intomainfrom Jul 30, 2025
Merged
Conversation
5 tasks
Collaborator
Author
|
I tried to fix the coverage for this line below, in the following commit: |
kclowes
approved these changes
Jul 10, 2025
Collaborator
kclowes
left a comment
There was a problem hiding this comment.
Nothing obvious stands out to me here! 🚀
marioevz
reviewed
Jul 11, 2025
Member
marioevz
left a comment
There was a problem hiding this comment.
Looks great! Just a couple of comments, thanks!
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py
Outdated
Show resolved
Hide resolved
3571174 to
193ea5e
Compare
cf09141 to
7e0c5c7
Compare
Collaborator
Author
|
Just commenting on the fixture diffs for the changes to the 4844 tests - Cancun/Prague:
|
5 tasks
marioevz
reviewed
Jul 28, 2025
Member
marioevz
left a comment
There was a problem hiding this comment.
Some comments which I feel would bring down the number of lines changed and also simplify code readabilit IMO, unless I'm missing something.
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py
Outdated
Show resolved
Hide resolved
6287172 to
e03bfcd
Compare
spencer-tb
commented
Jul 29, 2025
4 tasks
marioevz
approved these changes
Jul 29, 2025
Member
marioevz
left a comment
There was a problem hiding this comment.
Awesome work, thanks for the refactor I think changes look much simpler now.
Thanks!
57b729e to
6018bb9
Compare
51cb578 to
97399d4
Compare
5 tasks
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Following the changes to EIP-7594: ethereum/EIPs#9981
Adds some more
execute_blobstests for PeerDAS, including tests for the new max blobs per tx limit.Updates fork logic and EIP-4844 tests to use a new
max_blobs_per_txfunction.Adds specific tests for the new change (including transition tests) within the PeerDAS EIP testing folder.
Fill with the latest EELS
forks/osaka.Requires
🔗 Related Issues or PRs
#1798
Requires: #1784
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.