feat(tests): remove Blake2b max rounds static test#1941
feat(tests): remove Blake2b max rounds static test#1941marioevz merged 1 commit intoethereum:mainfrom
Conversation
marioevz
left a comment
There was a problem hiding this comment.
Yes, I agree, this case would make sense if we didn't constrain the transaction gas limit on Osaka, but now it's kinda meaningless.
We should add a test consumes the full block gas limit using many transactions of which each uses the most amount of rounds that fit in the new ~16M gas limit of the transaction.
|
I would even see the point of removing the entire I made an issue to track the porting of them to benchmark tests here: ethereum/execution-specs#1572 What do you think @chfast ? |
|
Merging this now, and will reconsider removing |
I think the 50000x SHA256 test can also be removed easily because it brings not much new coverage. Finally, the "sstore combinations" as the exhaustive test for one of the storage net metering EIPs. I don't think it has good replacement currently, but probably should be ported to pytest. |
🗒️ Description
This test brings no additional coverage and with 10G gas limit is very annoying. It is also included in the regular releases so on the Client side you have to filter it out because it runs to long.
There are also benchmarks for Blake2b, so if you think a case with very high number of rounds is desirable, I can add one more case to https://github.com/ethereum/execution-spec-tests/blob/main/tests/benchmark/test_worst_compute.py#L995.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.