core: implement eip-7778: block gas accounting without refunds#33593
Merged
rjl493456442 merged 4 commits intoethereum:masterfrom Mar 4, 2026
Merged
core: implement eip-7778: block gas accounting without refunds#33593rjl493456442 merged 4 commits intoethereum:masterfrom
rjl493456442 merged 4 commits intoethereum:masterfrom
Conversation
jrhea
reviewed
Jan 13, 2026
| @@ -661,9 +661,11 @@ func (st *stateTransition) returnGas() { | |||
| st.evm.Config.Tracer.OnGasChange(st.gasRemaining, 0, tracing.GasChangeTxLeftOverReturned) | |||
Contributor
There was a problem hiding this comment.
Do we want to update the enum comment? It currently says “returned to the chain,” which might be confusing post-Amsterdam. I figured I would point this out just in case.
go-ethereum/core/tracing/hooks.go
Lines 360 to 364 in 5a1990d
Contributor
There was a problem hiding this comment.
Yeah, it should definitely be updated to indicate that the refunds are only to accounts and not the gas pool after Amsterdam.
MariusVanDerWijden
force-pushed
the
eip-7778
branch
3 times, most recently
from
ad5c0ff to
7869c18
Compare
MariusVanDerWijden
force-pushed
the
eip-7778
branch
3 times, most recently
from
2af6f47 to
47490c3
Compare
MariusVanDerWijden
force-pushed
the
eip-7778
branch
2 times, most recently
from
e7793cd to
273c3d6
Compare
rjl493456442
force-pushed
the
eip-7778
branch
from
47549a0 to
87c071b
Compare
Draft
rjl493456442
approved these changes
Mar 4, 2026
rjl493456442
pushed a commit
that referenced
this pull request
Mar 5, 2026
Fixes a regression in #33593 where a block gas limit > gasCap resulted in more execution than the gas cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements https://eips.ethereum.org/EIPS/eip-7778