Skip to content

trie/bintrie: spec change, big endian hashing of slot key#34670

Open
gballet wants to merge 1 commit intoethereum:masterfrom
gballet:fix-endianness-get-tree-key-issue-after-overflow
Open

trie/bintrie: spec change, big endian hashing of slot key#34670
gballet wants to merge 1 commit intoethereum:masterfrom
gballet:fix-endianness-get-tree-key-issue-after-overflow

Conversation

@gballet
Copy link
Copy Markdown
Member

@gballet gballet commented Apr 6, 2026

The spec has been changed during SIC #49, the offset is encoded as a big-endian number.

@gballet gballet force-pushed the fix-endianness-get-tree-key-issue-after-overflow branch from add29e7 to ad758e1 Compare April 6, 2026 15:38
@gballet gballet marked this pull request as ready for review April 6, 2026 15:38
@gballet gballet requested a review from rjl493456442 as a code owner April 6, 2026 15:38
@gballet gballet added this to the 1.17.3 milestone Apr 6, 2026
Copy link
Copy Markdown
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestVerkleGenesisCommit fails and has to be adapted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants