Skip to content

trie/bintrie: spec change, big endian hashing of slot key #34670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gballet wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −7
Open

trie/bintrie: spec change, big endian hashing of slot key #34670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad758e1
trie/bintrie: spec change, big endian hashing of slot key
gballet Apr 6, 2026
42f0bc1
fix test
gballet Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions trie/bintrie/key_encoding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,12 @@ func getBinaryTreeKey(addr common.Address, offset []byte, overflow bool) []byte
defer returnSha256(hasher)
hasher.Write(zeroHash[:12])
hasher.Write(addr[:])
var buf [32]byte
// key is big endian, hashed value is little endian
for i := range offset[:31] {
buf[i] = offset[30-i]
}
var buf [32]byte // TODO: make offset a 33-byte value to avoid an extra stack alloc
copy(buf[1:32], offset[:31])
if overflow {
// Overflow detected when adding MAIN_STORAGE_OFFSET,
// reporting it in the shifter 32 byte value.
buf[31] = 1
buf[0] = 1
}
hasher.Write(buf[:])
k := hasher.Sum(nil)
Expand Down
Loading