Handle broken RFID in Openwb SW2.0#29352
Open
kaindl wants to merge 4 commits intoevcc-io:masterfrom
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When
identifyis enabled butwb.identify()fails, the error is silently ignored and RFID is effectively disabled; consider logging a warning in this case so users understand why RFID is not working despite having enabled it. - You removed the
"rfid"capability from the template even though RFID can still be explicitly enabled via the newidentifyflag; consider keeping the capability and gating behavior at runtime so that tooling or UI depending on capabilities can still detect optional RFID support.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When `identify` is enabled but `wb.identify()` fails, the error is silently ignored and RFID is effectively disabled; consider logging a warning in this case so users understand why RFID is not working despite having enabled it.
- You removed the `"rfid"` capability from the template even though RFID can still be explicitly enabled via the new `identify` flag; consider keeping the capability and gating behavior at runtime so that tooling or UI depending on capabilities can still detect optional RFID support.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
Apr 26, 2026
andig
reviewed
Apr 26, 2026
| if _, err := wb.identify(); err == nil { | ||
| identify = wb.identify | ||
| if cc.Identify { | ||
| if _, err := wb.identify(); err == nil { |
Contributor
Author
There was a problem hiding this comment.
which error check are you expecting here?
Member
There was a problem hiding this comment.
error needs be returned if != nil
andig
reviewed
Apr 26, 2026
Member
|
/cc @snaptec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already described in #27679 RFID-Handling in openWB is currently broken can mislead users!
It can lead to
Because these problems can lead to a very bad user experience for evcc-Users, this PR disables RFID-Authentication for openWB SW2.0 by default and adds Warnings about this behavior. RFID-Authentication can still be activated in Advanced settings.