Skip to content

Handle broken RFID in Openwb SW2.0 #29352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaindl wants to merge 4 commits into
base: master
Choose a base branch
from
+22 −3
Open

Handle broken RFID in Openwb SW2.0 #29352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a08060
openWB SW2.0: RFID currently broken
kaindl Feb 24, 2026
7d3520e
openWB SW2.0: Make RFID an option which is disabled by default
kaindl Apr 22, 2026
d960ced
removed unnecessary defaults (review by andig)
kaindl Apr 27, 2026
c9a48c3
Merge branch 'evcc-io:master' into openwb-2.0-broken-rfid
kaindl Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions charger/openwb-2.0.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,14 @@ func NewOpenWB20FromConfig(ctx context.Context, other map[string]any) (api.Charg
cc := struct {
Connector uint16
Phases1p3p bool
Identify bool
modbus.TcpSettings `mapstructure:",squash"`
}{
Connector: 1,
TcpSettings: modbus.TcpSettings{
ID: 1,
},
Identify: false,
Comment thread
kaindl marked this conversation as resolved.
Outdated
}

if err := util.DecodeOther(other, &cc); err != nil {
Expand All @@ -71,8 +73,10 @@ func NewOpenWB20FromConfig(ctx context.Context, other map[string]any) (api.Charg
}

var identify func() (string, error)
if _, err := wb.identify(); err == nil {
identify = wb.identify
if cc.Identify {
if _, err := wb.identify(); err == nil {
Copy link
Copy Markdown
Member

@andig andig Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing error check

Copy link
Copy Markdown
Contributor Author

@kaindl kaindl Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which error check are you expecting here?

Copy link
Copy Markdown
Member

@andig andig Apr 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error needs be returned if != nil

identify = wb.identify
}
}

return decorateOpenWB20(wb, phases1p3p, identify), nil
Expand Down
19 changes: 18 additions & 1 deletion templates/definition/charger/openwb-2.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ products:
- brand: openWB
description:
generic: Software 2.x
capabilities: ["1p3p", "mA", "rfid"]
capabilities: ["1p3p", "mA"]
requirements:
description:
de: |
Expand All @@ -12,12 +12,18 @@ requirements:
* Steuerungsmodus: `secondary`
* Steuerung über Modbus als secondary: `An`
RFID-Autorisierung ist mit openWB Software 2.x leider aktuell nicht sinnvoll nutzbar, siehe
[`Issue 2832`](https://github.com/openWB/core/issues/2832)
en: |
Requires [`Software 2.x`](https://github.com/openWB/core).
The following changes are necessary under the 'Einstellungen' tab:
* Steuerungsmodus: `secondary`
* Steuerung über Modbus als secondary: `An`
RFID-Authorisation currently is not usable with openWB Software 2.x, check
[`openWB Issue 2832`](https://github.com/openWB/core/issues/2832)
params:
- name: modbus
choice: ["tcpip"]
Expand All @@ -32,8 +38,19 @@ params:
de: Phasenumschaltung vorhanden
advanced: true
default: true
- name: identify
type: bool
description:
en: Use RFID-Reader
de: RFID-Reader verwenden
help:
en: Be sure to check openWB Issue 2832 before enabling this, should not be used for access protection!
de: Unbedingt openWB Issue 2832 beachten, sollte nicht für Zugangsschutz verwendet werden!
advanced: true
default: false
Comment thread
kaindl marked this conversation as resolved.
Outdated
render: |
type: openwb-2.0
{{- include "modbus" . }}
connector: {{ .connector }}
phases1p3p: {{ .phases1p3p }}
identify: {{ .identify }}
Loading