Fix PDF generation for pages with full paths for assets and without a specified base_url.#61
Merged
excid3 merged 2 commits intoexcid3:mainfrom Jul 15, 2025
Conversation
… specified base_url.
excid3
reviewed
Jul 15, 2025
Viktor-Ivliev
deleted the
broken-generating-pdf-with-full-paths-html-pages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.4.0 release broke the behavior of passing pure html with already full urls when no base_url is passed.
Example:
Raises an error:
undefined method 'end_with?' for nil