Skip to content

Fix PDF generation for pages with full paths for assets and without a specified base_url. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
excid3 merged 2 commits into from
Jul 15, 2025
Merged

Fix PDF generation for pages with full paths for assets and without a specified base_url. #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e915bc4
Fix PDF generation for pages with full paths for assets and without a…
Viktor-Ivliev Jul 15, 2025
20961aa
fix lint error
Viktor-Ivliev Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ferrum_pdf/html_preprocessor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ module HTMLPreprocessor
# process("Some HTML", "https://example.org")
#
def self.process(html, base_url)
return html if base_url.blank?

base_url += "/" unless base_url.end_with? "/"
protocol = base_url.split("://").first
html = translate_relative_paths(html, base_url) if base_url
Expand Down
5 changes: 5 additions & 0 deletions test/html_preprocessing_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ class HtmlPreProcessingTest< ActiveSupport::TestCase
assert_equal "<h1>Hello</h1>", FerrumPdf::HTMLPreprocessor.process("<h1>Hello</h1>", "https://example.org")
end

test "does not raise error when url absent" do
assert_equal "<a href=\"/example.pdf\">PDF</a>", FerrumPdf::HTMLPreprocessor.process("<a href=\"/example.pdf\">PDF</a>", nil)
assert_equal "<a href=\"/example.pdf\">PDF</a>", FerrumPdf::HTMLPreprocessor.process("<a href=\"/example.pdf\">PDF</a>", "")
end

test "replaces relative paths" do
assert_equal "<a href=\"http://example.org/example.pdf\">PDF</a>", FerrumPdf::HTMLPreprocessor.process("<a href=\"/example.pdf\">PDF</a>", "http://example.org")
assert_equal "<a href=\"https://example.com/example.pdf\">PDF</a>", FerrumPdf::HTMLPreprocessor.process("<a href=\"/example.pdf\">PDF</a>", "https://example.com")
Expand Down