-
-
Notifications
You must be signed in to change notification settings - Fork 746
sync the two-bucket tests and fix / add missing unit tests with display name #3052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41f9f7e to
d87bac4
Compare
jagdish-15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinri
Thanks for picking this up! Please apply the following change:
| @DisplayName("Measure using bucket one of size 2 and bucket two of size 3 - " + | ||
| "start with bucket one and end with bucket two") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @DisplayName("Measure using bucket one of size 2 and bucket two of size 3 - " + | |
| "start with bucket one and end with bucket two") | |
| @DisplayName( | |
| "Measure using bucket one of size 2 and bucket two of size 3 - " + | |
| "start with bucket one and end with bucket two" | |
| ) |
You can do this for the line being more than 120 characters. It aligns with what's been followed throughout the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jagdish-15 for the suggestion, I will update the MR when I am back home. I prefer to amend my commit with the change ;)
d87bac4 to
0c09d5f
Compare
0c09d5f to
f5fbe56
Compare
f5fbe56 to
f7ddd1c
Compare
|
I think you accidentally pushed the same commit without amending the changes. Could you please check? |
No I really push it. It is just that the second line has been indented by the code formatter. |
Co-authored-by: Jagdish Prajapati <[email protected]>
pull request
Sync two-bucket tests (implemented but not sync)
And implements the two missing tests
related to #2959 and #2971
Reviewer Resources:
Track Policies