Skip to content

Conversation

@xinri
Copy link
Contributor

@xinri xinri commented Nov 16, 2025

pull request

Sync two-bucket tests (implemented but not sync)
And implements the two missing tests

related to #2959 and #2971


Reviewer Resources:

Track Policies

@xinri xinri force-pushed the sync_two_bucket_tests branch from 41f9f7e to d87bac4 Compare November 17, 2025 00:11
Copy link
Member

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinri
Thanks for picking this up! Please apply the following change:

Comment on lines 76 to 77
@DisplayName("Measure using bucket one of size 2 and bucket two of size 3 - " +
"start with bucket one and end with bucket two")
Copy link
Member

@jagdish-15 jagdish-15 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@DisplayName("Measure using bucket one of size 2 and bucket two of size 3 - " +
"start with bucket one and end with bucket two")
@DisplayName(
"Measure using bucket one of size 2 and bucket two of size 3 - " +
"start with bucket one and end with bucket two"
)

You can do this for the line being more than 120 characters. It aligns with what's been followed throughout the repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jagdish-15 for the suggestion, I will update the MR when I am back home. I prefer to amend my commit with the change ;)

@xinri xinri force-pushed the sync_two_bucket_tests branch from d87bac4 to 0c09d5f Compare November 17, 2025 17:40
@xinri xinri requested a review from jagdish-15 November 17, 2025 17:40
@xinri xinri changed the title sync the two-bucket tests as they had been implemented but not sync sync the two-bucket tests and fix / add missing unit tests with display name Nov 17, 2025
@xinri xinri force-pushed the sync_two_bucket_tests branch from 0c09d5f to f5fbe56 Compare November 17, 2025 23:05
@xinri xinri force-pushed the sync_two_bucket_tests branch from f5fbe56 to f7ddd1c Compare November 17, 2025 23:13
@jagdish-15
Copy link
Member

I think you accidentally pushed the same commit without amending the changes. Could you please check?

@xinri
Copy link
Contributor Author

xinri commented Nov 18, 2025

I think you accidentally pushed the same commit without amending the changes. Could you please check?

No I really push it. It is just that the second line has been indented by the code formatter.
I put the name on the next line and the second line just after.

@xinri xinri requested a review from jagdish-15 November 18, 2025 10:34
@jagdish-15 jagdish-15 merged commit 1fdb762 into exercism:main Nov 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants