Conversation
|
Also, an important thing. I assume that the Docker account will be called exo, so that's a reason why in README.md there's a |
|
Thank you for your contribution! The exo codebase has undergone significant architectural changes since this PR was opened (event sourcing, new placement system, runner rewrite), and this PR now has merge conflicts that would require a substantial rewrite to resolve. We're closing this to keep the PR list focused, but the idea is still welcome — if you'd like to revisit this, please feel free to open a fresh PR against the current |
|
Reattempted the original PR #1288 with conflicts resolved. Thank you @KrzysztofZawisla Attn of: @AlexCheema - hoping to get this reviewed before future changes cause conflicts again -> #1945 (comment) |
Motivation
Some people, and I as well, wanted to run the exo in the Docker image to virtualize the whole environment. Here in this PR, you can find the Dockerfile, and GitHub CI workflow, which build and publish the image to Dockerhub. The repository owner has to provide secrets to make it work.
Related issue: #999
Changes
Test Plan
Idk, I'm not familiar with this repo. Maybe someone else will figure it out, how it can be tested in the complex way. I run that locally, and everything works as it should. Only the workflow is totally untested.
Manual Testing
Anything that runs Docker, and can run any model. I run that on Windows 11 with WSL2, Docker, 128gb of ram, and an RTX 4090.
Automated Testing
If it fails, then it fails on the Docker build stage in CI.
Additionial stuff
Please edit the target branch. I have set main, and I highly believe it shouldn't go to main