Closed
Conversation
nhwaani
approved these changes
Apr 20, 2026
Closed
Member
|
closing in favour of #1954. the nix builds skip all the env problems while being smaller and faster to build with less maintenance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Reattempt at this original PR - with conflicts resolved. Full credit to the original author @KrzysztofZawisla
#1288
Motivation
Some people, and I as well, wanted to run the exo in the Docker image to virtualize the whole environment. Here in this PR, you can find the Dockerfile, and GitHub CI workflow, which build and publish the image to Dockerhub. The repository owner has to provide secrets to make it work.
Related issue: #999
Changes
Added Dockerfile
Added .dockerignore
Added workflow to build and publish image to the Dockerhub
Added instructions to the README.md, how to use the Docker image and formatted the README.md file
Test Plan
Idk, I'm not familiar with this repo. Maybe someone else will figure it out, how it can be tested in the complex way. I run that locally, and everything works as it should. Only the workflow is totally untested.
Manual Testing
Anything that runs Docker, and can run any model. I run that on Windows 11 with WSL2, Docker, 128gb of ram, and an RTX 4090.
Automated Testing
If it fails, then it fails on the Docker build stage in CI.
Additionial stuff
Please edit the target branch. I have set main, and I highly believe it shouldn't go to main