Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[eas-cli] popup website in fingerprint:compare (#2859)" #2862

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 4, 2025

This reverts commit 7f46bae.

Temporarily reverting because we are in the process of changing the URL from the website

@quinlanj quinlanj merged commit 528988d into main Feb 4, 2025
6 checks passed
@quinlanj quinlanj deleted the @quin/revert-popup branch February 4, 2025 01:22
Copy link

github-actions bot commented Feb 4, 2025

✅ Thank you for adding the changelog entry!

Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

Size Change: +5.61 kB (+0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +5.61 kB (+0.01%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.41%. Comparing base (7f46bae) to head (2e092bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   52.39%   52.41%   +0.02%     
==========================================
  Files         589      589              
  Lines       23118    23110       -8     
  Branches     4839     4838       -1     
==========================================
- Hits        12111    12110       -1     
+ Misses      10040    10034       -6     
+ Partials      967      966       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

quinlanj added a commit that referenced this pull request Feb 4, 2025
quinlanj added a commit that referenced this pull request Feb 4, 2025
* Reapply "[eas-cli] popup website in fingerprint:compare (#2859)" (#2862)

This reverts commit 528988d.

* Temporary Commit at 2/4/2025, 11:36:07 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant