Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Narrow amount of data queried for basic update channel operations #2901

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Feb 10, 2025

Why

As we've added more features, we've added more fetched data to the default fragments (UpdateFragment). But a lot of callsites don't need all the data. This PR adds a new basic query for getting just the basic info (similar to other query below).

How

Add new query, replace callsites that can be replaces (rely on tsc to tell me)

Test Plan

yarn tsc

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman requested a review from quinlanj February 10, 2025 19:50
@wschurman wschurman marked this pull request as ready for review February 10, 2025 19:50
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien
packages/eas-cli/src/channel/** @quinlanj
packages/eas-cli/src/commands/channel/** @quinlanj

Generated by CodeMention

Copy link

github-actions bot commented Feb 10, 2025

Size Change: +2.09 kB (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB +2.09 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (911cc90) to head (2a5a88d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/graphql/queries/ChannelQuery.ts 0.00% 5 Missing and 1 partial ⚠️
packages/eas-cli/src/channel/queries.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/channel/delete.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/channel/edit.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/channel/pause.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/channel/resume.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   52.67%   52.65%   -0.01%     
==========================================
  Files         588      588              
  Lines       23188    23193       +5     
  Branches     4856     4857       +1     
==========================================
- Hits        12211    12210       -1     
- Misses      10011    10016       +5     
- Partials      966      967       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman force-pushed the @wschurman/02-10-_eas-cli_narrow_amount_of_data_queried_for_basic_update_channel_operations branch from 43b98bc to 580e578 Compare February 10, 2025 19:56
@wschurman wschurman force-pushed the @wschurman/02-10-_eas-cli_narrow_amount_of_data_queried_for_basic_update_channel_operations branch from 580e578 to 2a5a88d Compare February 12, 2025 04:07
Copy link

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 852dac0 into main Feb 12, 2025
7 checks passed
@wschurman wschurman deleted the @wschurman/02-10-_eas-cli_narrow_amount_of_data_queried_for_basic_update_channel_operations branch February 12, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants