Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(submit): Fix TestFlight internal group creation #2906

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Feb 12, 2025

Why

Failed to create an internal TestFlight group. This can be done manually in the App Store Connect website.
UnexpectedAppleResponse: The provided entity includes an attribute with an invalid value - Public link limit cannot be applied to internal group
  • Removing the extra properties may fix this, hard to explicitly verify.

How

  • Ensure the external TestFlight properties are removed when creating an internal group.

Test Plan

  • easd submit -p ios -> creates TF internal group without throwing an error.

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 12, 2025

Size Change: +764 B (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB +764 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.65%. Comparing base (918a7f9) to head (57de337).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   52.65%   52.65%           
=======================================
  Files         588      588           
  Lines       23193    23193           
  Branches     4857     4857           
=======================================
  Hits        12210    12210           
  Misses      10016    10016           
  Partials      967      967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✅ Thank you for adding the changelog entry!

@EvanBacon EvanBacon requested a review from szdziedzic February 12, 2025 21:11
@EvanBacon EvanBacon merged commit d7e48c2 into main Feb 13, 2025
10 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/submit/fix-testflight-group branch February 13, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants