Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(submit): Fix TestFlight internal group creation #2906

Merged
merged 4 commits into from
Feb 13, 2025
Merged

fix(submit): Fix TestFlight internal group creation #2906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bf7f4c
Update ensureTestFlightGroup.ts
EvanBacon Feb 12, 2025
fd15853
Update CHANGELOG.md
EvanBacon Feb 12, 2025
d02aa94
Merge branch 'main' into @evanbacon/submit/fix-testflight-group
EvanBacon Feb 12, 2025
57de337
bump apple utils
EvanBacon Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🐛 Bug fixes

- Fix internal TestFlight group creation. ([#2906](https://github.com/expo/eas-cli/pull/2906) by [@EvanBacon](https://github.com/EvanBacon))

### 🧹 Chores

- Narrow amount of data queried for basic update channel operations. ([#2901](https://github.com/expo/eas-cli/pull/2901) by [@wschurman](https://github.com/wschurman))
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"bugs": "https://github.com/expo/eas-cli/issues",
"dependencies": {
"@expo/apple-utils": "2.1.6",
"@expo/apple-utils": "2.1.9",
"@expo/code-signing-certificates": "0.0.5",
"@expo/config": "10.0.6",
"@expo/config-plugins": "9.0.12",
Expand Down
2 changes: 0 additions & 2 deletions packages/eas-cli/src/credentials/ios/appstore/ensureTestFlightGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ async function ensureInternalGroupAsync(app: App): Promise<BetaGroup> {
async () => {
betaGroup = await app.createBetaGroupAsync({
name: AUTO_GROUP_NAME,
publicLinkEnabled: false,
publicLinkLimitEnabled: false,
isInternalGroup: true,
// Automatically add latest builds to the group without needing to run the command.
hasAccessToAllBuilds: true,
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.