Add progress report for vtkF3DAssimpImporter#2703
Add progress report for vtkF3DAssimpImporter#2703Hy-LeTuan wants to merge 7 commits intof3d-app:masterfrom
vtkF3DAssimpImporter#2703Conversation
vtkF3DAssimpImporter
|
@mwestphal could you check this out please? |
|
Hi @Hy-LeTuan Need any help moving forward ? |
|
I think everything is all done? All tests passed on my machine |
Ill review, next time please ping me when you need a review :) |
|
Yes sir I'll ping you next time! |
|
\ci full |
|
Looks like |
|
Needs any help moving forward @Hy-LeTuan ? |
|
Still working on this @Hy-LeTuan ? |
|
There was a problem with a default test that is preventing the PR to be merged. I tried solving it but am still not sure what's wrong and you said you'd take a closer look so I'm waiting on your comments sir. |
I completely forgot! I will take a look |
|
Style Checks CI failed: |
Its caused the the ProgressEvent somehow, I need to investigate more |
|
There is a bug in VTK! It's a bit of a specific one though, in short, rendering the progress widget on top of the scene seems to render lights again, using the default light kit, which makes the final render completely incorrect. In order to workaround that just modify the TestDefaultConfigFileAssimpDAE to use |
mwestphal
left a comment
There was a problem hiding this comment.
needs a rebase on master and a small test change
Changes
Add progress reporting to
vtkF3DAssimpImporterin the Assimp plugin through attaching a derived class ofAssimp::ProgressHandleron the native Assimp reporter and use the parent importer to invoke progress report event.Continuation of this issue: #22