Skip to content

Add progress report for vtkF3DAssimpImporter #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hy-LeTuan wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add progress report for vtkF3DAssimpImporter #2703

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1865254
add progress handler for assimp importer
Hy-LeTuan Dec 9, 2025
0064d4b
fix percentage handling in update
Hy-LeTuan Dec 9, 2025
9222a66
assert default progress handler is active
Hy-LeTuan Dec 11, 2025
6d27f99
move handler creation after assert
Hy-LeTuan Dec 11, 2025
8c2228c
Merge branch 'master' into fbx-importer
Hy-LeTuan Dec 16, 2025
b507509
move class definition and declaration to separate header
Hy-LeTuan Dec 25, 2025
10aac7d
Merge branch 'master' into fbx-importer
Hy-LeTuan Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions plugins/assimp/module/vtkF3DAssimpImporter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
#include "vtkF3DAssimpImporter.h"

#include <assimp/ProgressHandler.hpp>
#include <vtkActor.h>
#include <vtkActorCollection.h>
#include <vtkCamera.h>
#include <vtkCommand.h>
#include <vtkDoubleArray.h>
#include <vtkFloatArray.h>
#include <vtkImageData.h>
Expand Down Expand Up @@ -42,6 +44,27 @@
#include <memory>
#include <regex>

class F3DAssimpProgressHandler : public Assimp::ProgressHandler
{
public:
explicit F3DAssimpProgressHandler(vtkF3DAssimpImporter* parent)
: Parent(parent)
{
}

bool Update(float percentage = -1.f) override
{
double reportPercentage = percentage < 0 ? double{ 1.0 } : static_cast<double>(percentage);

this->Parent->InvokeEvent(vtkCommand::ProgressEvent, static_cast<void*>(&reportPercentage));

return percentage < 0 ? false : true;
}

private:
vtkF3DAssimpImporter* Parent;
};

vtkStandardNewMacro(vtkF3DAssimpImporter);

class vtkF3DAssimpImporter::vtkInternals
Expand All @@ -51,6 +74,12 @@ class vtkF3DAssimpImporter::vtkInternals
explicit vtkInternals(vtkF3DAssimpImporter* parent)
: Parent(parent)
{
auto progressHandler = new F3DAssimpProgressHandler(parent);

if (this->Importer.IsDefaultProgressHandler())
{
this->Importer.SetProgressHandler(static_cast<Assimp::ProgressHandler*>(progressHandler));
}
}

//----------------------------------------------------------------------------
Expand Down