feat(core): useTypeahead hook + DropdownMenu integration (menus-11)#3431
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
josephfarina
approved these changes
Jul 2, 2026
Contributor
Author
|
fix conflicts |
d50cb73 to
ddcb354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the accessibility & keyboard-management program (#3343). Adds the typeahead primitive the audit calls for (
infra-14) and closesmenus-11for DropdownMenu.What this adds
useTypeahead— a first-character ("type-to-focus") search hook:Spacefor activation (only extends the query mid-buffer).onMatchto its own focus/selection (e.g.useListFocus.focusItem). No change touseListFocus/useGridFocus, so it's independent of the roving-engine consolidation discussion.Wired into DropdownMenu
DropdownMenu's key handler now runs typeahead before arrow navigation — typing a letter jumps to the matching menu item. Menus previously had no typeahead (an APG Menu requirement).Tests
useTypeahead.test.tsx(7): match, buffer accumulation, same-letter cycling + wrap, timeout reset, disabled-skip, control/modifier ignore, bare-Space ignore.DropdownMenu.test.tsx(+1): typing focuses the matching item. Full suites green (39 tests), typecheck + lint clean.Follow-up
Wire
useTypeaheadinto ContextMenu/NavMenu/MoreMenu (samelistKeyDownseam) and the Selector family (replace its restart-at-0 matcher) — deferred to focused follow-ups.