fix(Chat): align composer tokens to middle instead of synthesized baseline - #5324
Open
athz wants to merge 1 commit into
Open
fix(Chat): align composer tokens to middle instead of synthesized baseline#5324athz wants to merge 1 commit into
athz wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
August 22, 2026 06:20
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsChat (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. Chat - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
rubyycheung
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tokens inserted into
ChatComposerInputsit a few pixels high relative to typed text. The text appears to sag below the chip.Root cause
Three things compound:
<span>withdisplay: inline-flexandvertical-align: baseline.vertical-align: baselinetherefore aligns the chip's bottom edge to the text baseline, rather than the chip's label baseline. The visual gap equals roughly the label's descender depth.Fix
Both sites changed together (they must stay in sync):
useChatComposerTokens(imperative span created on token insert):vertical-align→middleChatComposerTokenElement(exported React component): moved from inline style to a StyleX class withvertical-align: middlemiddleis the conventional alignment for an inline chip taller than its surrounding text — it centers the chip's midpoint on the parent's x-height midpoint, producing visually centered alignment regardless of icon presence.Bonus: StyleX over inline style
ChatComposerTokenElementpreviously usedstyle={{ display: 'inline-flex', verticalAlign: 'baseline' }}. An inline style is unreachable from a stylesheet without!important, so consumers had no clean way to adjust alignment. It now uses a StyleX class, making it overridable through normal specificity.Risk
Low. No test pins the previous value (verified — the only
verticalAlignassertions in the suite are in Table). All 51 Chat tests pass unchanged.