Skip to content

fix(Chat): align composer tokens to middle instead of synthesized baseline #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
athz wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

fix(Chat): align composer tokens to middle instead of synthesized baseline #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-chat-token-alignment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@astryxdesign/core': patch
---

[fix] Chat: composer tokens no longer sit above surrounding text — `vertical-align` changed from `baseline` to `middle`, and `ChatComposerTokenElement` now uses a StyleX class instead of an inline style so consumers can override alignment without `!important`.

@athz
6 changes: 5 additions & 1 deletion packages/core/src/Chat/ChatComposerInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ const styles = stylex.create({
opacity: 0.5,
pointerEvents: 'none' as const,
},
tokenSpan: {
display: 'inline-flex',
verticalAlign: 'middle',
},
});

// =============================================================================
Expand Down Expand Up @@ -749,7 +753,7 @@ export function ChatComposerTokenElement({token}: {token: ChatComposerToken}) {
data-astryx-token=""
data-astryx-token-value={token.value}
contentEditable={false}
style={{display: 'inline-flex', verticalAlign: 'baseline'}}>
{...stylex.props(styles.tokenSpan)}>
{isCustomToken(token) ? (
token.render()
) : (
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/Chat/useChatComposerTokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function useChatComposerTokens({
span.setAttribute('data-astryx-token-id', id);
span.contentEditable = 'false';
span.style.display = 'inline-flex';
span.style.verticalAlign = 'baseline';
span.style.verticalAlign = 'middle';

range.deleteContents();
range.insertNode(span);
Expand Down
Loading