allow one-line install of the latest version#17
Conversation
hn8
commented
Mar 4, 2024
- remove version from filename and rename arm64 to aarch64 (uname -m) for one-line install
- version-pinned urls are still avaiable as https://github.com/facebook/dotslash/releases/download/v0.3.0/dotslash-macos.tar.gz
- maximize gzip compression level
|
Hi @hn8! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Note that the way we solve this in Sapling is that the website uses https://sapling-scm.com/docs/introduction/installation I think it's good to keep it so my |
It is one-line install with pipe, so no file would show up in ~/Downloads. |
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bigfootjon merged this pull request in 4edcc9a. |
|
I had to revert this as it breaks the |
|
This pull request has been reverted by 723dd8e. |
|
@bolinfest, @hn8: as an FYI, I'm going to try and re-enable this. Step one is in #64 where we will upload both versioned and non-versioned artifacts. I'll then fix the action to be a bit smarter (which is why this was reverted initially). At some point in the future, we'll only have non-versioned artifacts. The reason why I'm doing this is that we're trying to get a working Dev Container feature (currently checked in, but not documented yet), and with the version number in the artifact, we run the risk of getting rate-limited by GitHub when trying to install the feature. |
Please don't remove the versioned artifacts. Some of us want to be able to consistently install a specific version of dotslash (and not just "latest"; every piece of software has occasional regressions) and versioned artifacts make that much easier. |
|
We'll still have versions and releases. The binary artifacts that we upload to each release just won't have the version number present in the file name, as it makes it quite difficult to install the latest version with a one-liner for those who want to. |
|
If you want to track when the assets with version numbers in their name go away, you can subscribe to #68. No promises when we get to it, but that will have the status. |
Summary: This re-implements #17 now that we have fixed the underlying issues that caused it to get reverted in the first place. I've done the documentation a bit differently to try and make it a bit cleaner. I also did not update the versioned artifacts that are due for removal in #68. Pull Request resolved: #72 Reviewed By: bigfootjon Differential Revision: D77397668 Pulled By: sdwilsh fbshipit-source-id: fdf9d7b90bfade637ed2acf1934460c5d0739abf