Fix performance issue: Cache background sync job queries and skip on … #3823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
Contributor
📦 Latest Plugin BuildBuilt at: 2026-01-26T17:37:13.669Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
vahidkay-meta
requested changes
Jan 21, 2026
| $is_empty = intval( $count ) === 0; | ||
|
|
||
| // Cache the result indefinitely - it will be invalidated when job status changes | ||
| set_transient( $this->queue_empty_cache_key, $is_empty ? 'empty' : 'not_empty', 0 ); |
Contributor
There was a problem hiding this comment.
I'd put something like 1h for the expiration, just in case.
| */ | ||
| protected function is_queue_empty() { | ||
| // Skip expensive query on frontend - only needed in admin/ajax/cron contexts | ||
| if ( ! is_admin() && ! wp_doing_ajax() && ! wp_doing_cron() && ! $this->is_process_request() ) { |
Contributor
There was a problem hiding this comment.
so the only case where the method should run is:
if it's an admin user, making an ajax call, through cron?
| */ | ||
| protected function is_queue_empty() { | ||
| // Skip expensive query on frontend - only needed in admin/ajax/cron contexts | ||
| if ( ! is_admin() && ! wp_doing_ajax() && ! wp_doing_cron() && ! $this->is_process_request() ) { |
Contributor
There was a problem hiding this comment.
What is the is_process_request method? I cannot find the implementation of it
| * Tests focus on the is_sync_in_progress() method and its behavior | ||
| * with caching and frontend guards. | ||
| */ | ||
| class SyncTest extends AbstractWPUnitTestWithOptionIsolationAndSafeFiltering { |
Contributor
There was a problem hiding this comment.
Could you also test the happy-path ( when a sync is in progress ), using an E2E test?
added 4 commits
January 26, 2026 17:36
…frontend - Add transient-based caching to is_queue_empty() and get_jobs() methods - Add frontend guards to prevent expensive queries on frontend requests - Cache persists until explicitly invalidated (no time-based expiry) - Invalidate cache when jobs are created, completed, failed, or deleted - Update DebugTools to clear cache when cleaning up old sync options - Add comprehensive unit tests for caching and frontend guard logic This fixes the slow SQL query (SELECT ... LIKE '%status:processing%') that was running on every frontend request, causing 1.5+ second delays.
The caching for sync status is implemented at the higher level in is_sync_in_progress() in Sync.php, not in get_jobs() directly. Updated tests to reflect the actual implementation.
devbodaghe
force-pushed
the
fix/background-sync-performance
branch
from
f4dfbd1 to
0c295c0
Compare
|
@devbodaghe has imported this pull request. If you are a Meta employee, you can view this in D91487986. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a severe performance issue where an expensive SQL query was running on every frontend page load, causing 1.5+ second delays and timeout errors.
The Problem:
The query
SELECT option_value FROM wp_options WHERE option_name LIKE 'wc_facebook_background_product_sync_job_%' AND (option_value LIKE '%"status":"processing"%')was executing on every request because:LIKEclauses cannot use indexes efficiently, causing full table scansThe Solution:
is_queue_empty()andget_jobs()now return early on frontend requests (when not in admin, AJAX, or cron context)Impact: This single query accounted for ~25% of total page load time on affected stores.
Type of change
Checklist
Changelog entry
Fix: Resolved performance issue where background sync job queries caused slow page loads on frontend requests.
Test Plan
Automated Tests
Run the new unit tests:
./vendor/bin/phpunit --filter BackgroundJobHandlerTest
./vendor/bin/phpunit --filter SyncTest
./vendor/bin/phpunit --filter DebugToolsTestResults: 46 tests, 98 assertions - all passing
Manual Testing
Frontend Performance Test:
wc_facebook_background_product_sync_job_%query no longer appearsAdmin Functionality Test:
Cache Invalidation Test:
get_transient('wc_facebook_background_product_sync_queue_empty')Debug Tools Test:
Screenshots
Before
Query Monitor showing the expensive query on every frontend request:
SELECT option_value FROM wp_options WHERE option_name LIKE 'wc_facebook_background_product_sync_job_%' AND (option_value LIKE '%"status":"processing"%')After