[Nexthop][m4062nhp] Use stable paths for DIMM temp sensors - #1540
Open
anna-nexthop wants to merge 1 commit into
Open
[Nexthop][m4062nhp] Use stable paths for DIMM temp sensors#1540anna-nexthop wants to merge 1 commit into
anna-nexthop wants to merge 1 commit into
Conversation
The DDR5 SPD hubs are auto-instantiated by the kernel and the i2c paths may change depending on the module load order. Resolve the DIMM temp sensor to a stable path provided by the BSP. Signed-off-by: Anna Komarova <anna@nexthop.ai>
somasun
reviewed
Aug 20, 2026
| "pmUnitScopedName": "DIMM2_TEMP", | ||
| "sysfsPath": "/sys/bus/i2c/devices/1-0051" | ||
| "sysfsPath": "/run/nexthop_bsp/sensors/DIMM2_TEMP" | ||
| } |
Contributor
There was a problem hiding this comment.
This shouldn't have slipped in. Thanks for the fix. Wondering if we can update platform_manager/ConfigValidator to allow only stable paths?
Contributor
Author
There was a problem hiding this comment.
@somasun I think that's an improvement if that is indeed the intention. However, I'm hesitant about adding it as part of this change since that's a narrowing requirement and I don't know how many other platforms might be flagged, so proposing to have that improvement be in its own PR.
anna-nexthop
marked this pull request as ready for review
August 21, 2026 18:13
Contributor
|
@somasun has imported this pull request. If you are a Meta employee, you can view this in D116974647. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The DDR5 SPD hubs are auto-instantiated by the kernel and the i2c paths may change depending on the module load order. Resolve the DIMM temp sensor to a stable path provided by the BSP.
Test Plan
Verified on hardware.