Skip to content

[Nexthop][m4062nhp] Use stable paths for DIMM temp sensors #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anna-nexthop wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

[Nexthop][m4062nhp] Use stable paths for DIMM temp sensors #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fboss/platform/configs/m4062nhp/platform_manager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@
"embeddedSensorConfigs": [
{
"pmUnitScopedName": "DIMM1_TEMP",
"sysfsPath": "/sys/bus/i2c/devices/1-0050"
"sysfsPath": "/run/nexthop_bsp/sensors/DIMM1_TEMP"
},
{
"pmUnitScopedName": "DIMM2_TEMP",
"sysfsPath": "/sys/bus/i2c/devices/1-0051"
"sysfsPath": "/run/nexthop_bsp/sensors/DIMM2_TEMP"
}

@somasun somasun Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have slipped in. Thanks for the fix. Wondering if we can update platform_manager/ConfigValidator to allow only stable paths?

@anna-nexthop anna-nexthop Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somasun I think that's an improvement if that is indeed the intention. However, I'm hesitant about adding it as part of this change since that's a narrowing requirement and I don't know how many other platforms might be flagged, so proposing to have that improvement be in its own PR.

],
"outgoingSlotConfigs": {
Expand Down
Loading