use C++ Native Animated from JS if enabled #51337
Open
+83
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74490166 |
|
This pull request was exported from Phabricator. Differential Revision: D74490166 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: facebook#51337 changelog: [internal] When C++ Native Animated is used, we can't be using TurboModuleAnimated native module. This diff just add the check to make sure that if C++ Native Animated is used, it will be correctly referenced from JS. Reviewed By: lenaic Differential Revision: D74490166
sammy-SC
force-pushed
the
export-D74490166
branch
from
1ef094e to
67a999d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74490166 |
sammy-SC
force-pushed
the
export-D74490166
branch
from
67a999d to
81e1d7d
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: facebook#51337 changelog: [internal] When C++ Native Animated is used, we can't be using TurboModuleAnimated native module. This diff just add the check to make sure that if C++ Native Animated is used, it will be correctly referenced from JS. Reviewed By: lenaic Differential Revision: D74490166
|
This pull request was exported from Phabricator. Differential Revision: D74490166 |
sammy-SC
force-pushed
the
export-D74490166
branch
from
81e1d7d to
4075e4c
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: facebook#51337 changelog: [internal] When C++ Native Animated is used, we can't be using TurboModuleAnimated native module. This diff just add the check to make sure that if C++ Native Animated is used, it will be correctly referenced from JS. Reviewed By: lenaic Differential Revision: D74490166
Differential Revision: D74738548
…iewOnUIThread Differential Revision: D74739294
Summary: Pull Request resolved: facebook#51337 changelog: [internal] When C++ Native Animated is used, we can't be using TurboModuleAnimated native module. This diff just add the check to make sure that if C++ Native Animated is used, it will be correctly referenced from JS. Reviewed By: lenaic Differential Revision: D74490166
|
This pull request was exported from Phabricator. Differential Revision: D74490166 |
sammy-SC
force-pushed
the
export-D74490166
branch
from
4075e4c to
6b6feda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
When C++ Native Animated is used, we can't be using TurboModuleAnimated native module. This diff just add the check to make sure that if C++ Native Animated is used, it will be correctly referenced from JS.
Differential Revision: D74490166