-
Notifications
You must be signed in to change notification settings - Fork 330
feat: cache invalidation on .babelrc update #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5db7b69
to
3c60939
Compare
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick before I merge this.
try { | ||
await fs.access(babelrcPath); | ||
console.log('Found babelrc:', babelrcPath); | ||
return babelrcPath; | ||
} catch { | ||
currentDir = path.dirname(currentDir); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use fs.access
. Use fs.exists
instead. That returns a boolean and won't throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback fs.exists
is deprecated and may cause issues with modern node versions. if error specificity isn't a concern we can use fs.exists
but it might require updates later, which could impact maintainability
Also needs to be rebased. |
49c27bc
to
92ea4fb
Compare
92ea4fb
to
fa5182c
Compare
This PR is still not ready to merge. It has a bunch of extra commits from other PRs that have already merged. I think it needs to be rebased. |
this should be safe to merge, iirc when you squash, it commits only the changes seen in the file diff. so even though the commit history of the PR is wonky, Github is aware of the latest state of origin/main. |
What changed / motivation ?
Let's add cache invalidation on .babelrc config update
Testing
Added tests writing .babelrc update
Pre-flight checklist
Contribution Guidelines