-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache invalidation on .babelrc update #865
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1703c35
feat: replace crypto with murmurhash for cli caching
mellyeliu 493c789
fix: fix readCache to use custom cache path when set
mellyeliu 55d4190
feat: make filepath relative for cache portability
mellyeliu 65ae1f3
fix: fix readCache to use custom cache path when set
mellyeliu 8710eb4
merge fix
mellyeliu 2dcdec3
fix: fix readCache to use custom cache path when set
mellyeliu e40a320
merge
mellyeliu 9263ca9
fix: fix readCache to use custom cache path when set
mellyeliu f46d0df
merge main
mellyeliu 0f630a7
fix dir
mellyeliu 6a77536
fix relative path
mellyeliu 67835a4
fix: add cache invalidation when on config change
mellyeliu 3c60939
feat: add cache invalidation on update of nearest .babelrc update
mellyeliu fa5182c
Merge branch 'main' of github.com:facebook/stylex into cli-cache-babel
mellyeliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use
fs.access
. Usefs.exists
instead. That returns a boolean and won't throw an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback
fs.exists
is deprecated and may cause issues with modern node versions. if error specificity isn't a concern we can usefs.exists
but it might require updates later, which could impact maintainability