Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add theming recipes #869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: Add theming recipes #869

wants to merge 2 commits into from

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jan 18, 2025

What changed / motivation ?

Adds three more recipes all related to theming.

1. Reset Themes

Explains how using stylex.createTheme(vars, {}) creates a theme that resets variables to their default values.

2. Merge Themes

Shows how to define object constants outside stylex.createTheme calls to be able to reuse and merge objects and avoid repetition.

3. light-dark

Talks about using the light-dark() function to control the color-scheme instead of defining three light, dark and system themes explicitly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.Wovxou5S9K /tmp/tmp.Mig4rKXsXX

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,110 567,110 1.00
· minified 10,232,512 10,232,512 1.00
rollup-example/.build/stylex.css
· compressed 100,628 100,628 1.00
· minified 755,718 755,718 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants