Enable RTTI to fix exception pointer issue on React Native #1791
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Feb 28, 2025
…1791) Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
d1b1eae to
37d8eed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
force-pushed
the
export-D70386744
branch
from
37d8eed to
de17dd9
Compare
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Feb 28, 2025
…1791) Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Differential Revision: D70386744
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
de17dd9 to
6603ce1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
force-pushed
the
export-D70386744
branch
from
6603ce1 to
a798dd7
Compare
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
a798dd7 to
a2985d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
a2985d6 to
2e6fedc
Compare
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
2e6fedc to
4c1dedb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 3, 2025
…1791) Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
4c1dedb to
978d72e
Compare
cortinico
added a commit
to cortinico/yoga
that referenced
this pull request
Mar 4, 2025
…1791) Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
cortinico
force-pushed
the
export-D70386744
branch
from
978d72e to
0ab71d9
Compare
…1791) Summary: Pull Request resolved: facebook#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: facebook/react-native#48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Reviewed By: javache, NickGerleman Differential Revision: D70386744
|
This pull request was exported from Phabricator. Differential Revision: D70386744 |
cortinico
force-pushed
the
export-D70386744
branch
from
0ab71d9 to
c91093c
Compare
|
This pull request has been merged in 1b7d2c8. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 4, 2025
Summary: X-link: facebook/yoga#1791 Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: #48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native bypass-github-export-checks Reviewed By: javache, NickGerleman Differential Revision: D70386744 fbshipit-source-id: 36e3a1ddb38346d31979d5c1b77d6e9796d6a855
|
amazing find nicola. I'll test this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS.
Fixes: facebook/react-native#48027
Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole
React Native build so it probably makes sense to have it enabled for Yoga as well.
Changelog:
[Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native
Differential Revision: D70386744