Fix params #56
Closed
Fix params #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74500602 |
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
May 12, 2025
Summary: There were several problems here: v11 integer params have no length includeParam was wrong for setup Reviewed By: sharmafb Differential Revision: D74500602
|
This pull request was exported from Phabricator. Differential Revision: D74500602 |
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
May 12, 2025
Summary: Pull Request resolved: facebookexperimental#56 There were several problems here: v11 integer params have no length includeParam was wrong for setup Reviewed By: sharmafb Differential Revision: D74500602
Summary: There's a marginally gross hack here where I keep a single map of "FullTrackName" to RequestID for legacy verions. For TrackStatus its the real FTN, for ANNOUNCE and SUB_ANNOUNCES it's a fake FTN with eg (NS, "announce"). It could break if someone has a track name or namespace tuple called "announce" or "subannounce". Differential Revision: https://www.internalfb.com/diff/D74147358
Differential Revision: D74530554
Differential Revision: D74500562
afrind
added a commit
to afrind/moxygen
that referenced
this pull request
May 13, 2025
Summary: There were several problems here: v11 integer params have no length includeParam was wrong for setup Reviewed By: sharmafb Differential Revision: D74500602
Summary: Pull Request resolved: facebookexperimental#56 There were several problems here: v11 integer params have no length includeParam was wrong for setup Reviewed By: sharmafb Differential Revision: D74500602
|
This pull request was exported from Phabricator. Differential Revision: D74500602 |
|
This pull request has been merged in 6a0d512. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There were several problems here:
v11 integer params have no length
includeParam was wrong for setup
Reviewed By: sharmafb
Differential Revision: D74500602