Skip to content

Fix params #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix params #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6899ed8
Add Request ID to new messages
afrind May 13, 2025
4f8e29d
Request ID part 2 - increment by 2
afrind May 13, 2025
524b72b
Run tests for all versions
afrind May 13, 2025
e4b1b20
Fix params (#56)
afrind May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 169 additions & 54 deletions moxygen/MoQFramer.cpp
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions moxygen/MoQFramer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,15 +672,18 @@ struct SubscribeDone {
};

struct Announce {
RequestID requestID;
TrackNamespace trackNamespace;
std::vector<TrackRequestParameter> params;
};

struct AnnounceOk {
RequestID requestID;
TrackNamespace trackNamespace;
};

struct AnnounceError {
RequestID requestID;
TrackNamespace trackNamespace;
AnnounceErrorCode errorCode;
std::string reasonPhrase;
Expand All @@ -697,11 +700,13 @@ struct AnnounceCancel {
};

struct TrackStatusRequest {
RequestID requestID;
FullTrackName fullTrackName;
std::vector<TrackRequestParameter> params; // draft-11 and later
};

struct TrackStatus {
RequestID requestID;
FullTrackName fullTrackName;
TrackStatusCode statusCode;
folly::Optional<AbsoluteLocation> latestGroupAndObject;
Expand Down Expand Up @@ -827,15 +832,18 @@ struct FetchError {
};

struct SubscribeAnnounces {
RequestID requestID;
TrackNamespace trackNamespacePrefix;
std::vector<TrackRequestParameter> params;
};

struct SubscribeAnnouncesOk {
RequestID requestID;
TrackNamespace trackNamespacePrefix;
};

struct SubscribeAnnouncesError {
RequestID requestID;
TrackNamespace trackNamespacePrefix;
SubscribeAnnouncesErrorCode errorCode;
std::string reasonPhrase;
Expand Down
Loading
Loading