Only set -fvisibility-inlines-hidden for C++ code - #48
Closed
alexmalyshev wants to merge 1 commit into
Closed
Conversation
GCC will warn when its set for C code.
meta-cla
Bot
added
the
CLA Signed
|
@alexmalyshev has imported this pull request. If you are a Meta employee, you can view this in D103699796. |
|
@alexmalyshev merged this pull request in 2c5d704. |
grantlouisherman
pushed a commit
to grantlouisherman/cinderx
that referenced
this pull request
May 5, 2026
Summary: GCC will warn when its set for C code and it gets noisy. Pull Request resolved: facebookincubator#48 Reviewed By: yoney Differential Revision: D103699796 Pulled By: alexmalyshev fbshipit-source-id: ae2c1000eb05a3aeaf39124a1f084190669fa4c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC will warn when its set for C code and it gets noisy.