test: Use VectorFuzzer for random RowVector generation in semiJoinDeduplicateResetCapacity test#15748
Closed
liujiayi771 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
test: Use VectorFuzzer for random RowVector generation in semiJoinDeduplicateResetCapacity test#15748liujiayi771 wants to merge 1 commit intofacebookincubator:mainfrom
semiJoinDeduplicateResetCapacity test#15748liujiayi771 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Contributor
Author
liujiayi771
force-pushed
the
dedup-hash-build-ut
branch
from
7772ce6 to
73e52cc
Compare
Contributor
Author
|
@rui-mo Could you please help review this? As suggested by @bikramSingh91 in #7066, I've replaced random with VectorFuzzer. |
liujiayi771
force-pushed
the
dedup-hash-build-ut
branch
from
73e52cc to
e516390
Compare
liujiayi771
force-pushed
the
dedup-hash-build-ut
branch
from
e516390 to
9087d37
Compare
rui-mo
added
the
ready-to-merge
Collaborator
|
Marking as ready-to-merge if no further comments, thanks! cc: @bikramSingh91 |
rui-mo
changed the title
semiJoinDeduplicateResetCapacity test
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this in D98980592. |
Contributor
|
@liujiayi771 can you please rebase? the land got aborted due to a merge conflict |
…plicateResetCapacity
liujiayi771
force-pushed
the
dedup-hash-build-ut
branch
from
9087d37 to
0574e36
Compare
Build Impact AnalysisSelective Build Targets (building these covers all 1 affected)Total affected: 1/556 targets Affected targets (1)Directly changed (1)
Fast path • Graph from main@4a966b2effd240f9d9f43e0b9305c0bdd7cd6b39 |
|
@bikramSingh91 merged this pull request in 37e897b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7066.
Replace rand() with VectorFuzzer for random RowVector generation in semiJoinDeduplicateResetCapacity