Skip to content

test: Use VectorFuzzer for random RowVector generation in semiJoinDeduplicateResetCapacity test #15748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liujiayi771 wants to merge 1 commit into from
+12 −19
Closed

test: Use VectorFuzzer for random RowVector generation in semiJoinDeduplicateResetCapacity test #15748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions velox/exec/tests/HashJoinTestExtra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3838,26 +3838,19 @@

TEST_P(HashJoinTest, semiJoinDeduplicateResetCapacity) {
const int32_t vectorSize = 10;
const int32_t batches = 210;
auto probeVectors = makeBatches(batches, [&](int32_t /*unused*/) {
return makeRowVector({
// Join Key is double -> VectorHasher::typeKindSupportsValueIds will
// return false -> HashMode is kHash
makeFlatVector<double>(
vectorSize, [&](vector_size_t /*row*/) { return rand(); }),
makeFlatVector<int64_t>(
vectorSize, [&](vector_size_t /*row*/) { return rand(); }),
});
});
const int32_t numBatches = 210;
VectorFuzzer fuzzer({.vectorSize = vectorSize}, pool());

auto buildVectors = makeBatches(batches, [&](int32_t batch) {
return makeRowVector({
makeFlatVector<double>(
vectorSize, [&](vector_size_t /*row*/) { return rand(); }),
makeFlatVector<int64_t>(
vectorSize, [&](vector_size_t /*row*/) { return rand(); }),
});
});
// Row type with double and int64_t columns
// Join Key is double -> VectorHasher::typeKindSupportsValueIds will
// return false -> HashMode is kHash
auto rowType = ROW({"c0", "c1"}, {DOUBLE(), BIGINT()});

Check warning on line 3847 in velox/exec/tests/HashJoinTestExtra.cpp

View workflow job for this annotation

GitHub Actions / Build with GCC / Linux release with adapters

misc-include-cleaner 

no header providing "facebook::velox::DOUBLE" is directly included

auto probeVectors = makeBatches(
numBatches, [&](int32_t /*unused*/) { return fuzzer.fuzzRow(rowType); });

auto buildVectors = makeBatches(
numBatches, [&](int32_t /*unused*/) { return fuzzer.fuzzRow(rowType); });

createDuckDbTable("t", probeVectors);
createDuckDbTable("u", buildVectors);
Expand Down
Loading